fix: don't disable presolve and fix dual value retrieval for SCIP#441
Merged
FabianHofmann merged 5 commits intomasterfrom Apr 15, 2025
Merged
fix: don't disable presolve and fix dual value retrieval for SCIP#441FabianHofmann merged 5 commits intomasterfrom
FabianHofmann merged 5 commits intomasterfrom
Conversation
FabianHofmann
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes # (if applicable).
Changes proposed in this Pull Request
Feedback from SCIP developers in open-energy-transition/solver-benchmark#148 indicates that linopy might be making an error when retrieving dual solution values from SCIP. Also, they recommend against disabling presolve, which might have been done in order to retrieve dual solution values. This PR makes both changes.
I think we might not need a separate function for LPs and MILPs, since the dual retrieval code is in an if-then block?
We should also test that removing the code that filters dual variable names to only those starting with
corcfis no longer necessary.Checklist
doc.doc/release_notes.rstof the upcoming release is included.